alamb commented on code in PR #13066:
URL: https://github.com/apache/datafusion/pull/13066#discussion_r1811274005
##########
datafusion/sqllogictest/test_files/subquery.slt:
##########
@@ -542,13 +542,13 @@ query TT
explain SELECT t0_id, t0_name FROM t0 WHERE EXISTS (SELECT 1 FROM t1 INNER
JOIN t2 ON(t1.t1_id = t2.t2_id and t1.t1_name = t0.t0_name))
----
logical_plan
-01)Filter: EXISTS (<subquery>)
-02)--Subquery:
-03)----Projection: Int64(1)
-04)------Inner Join: Filter: t1.t1_id = t2.t2_id AND t1.t1_name =
outer_ref(t0.t0_name)
-05)--------TableScan: t1
-06)--------TableScan: t2
-07)--TableScan: t0 projection=[t0_id, t0_name]
+01)LeftSemi Join: t0.t0_name = __correlated_sq_2.t1_name
Review Comment:
🎉
##########
datafusion/optimizer/src/optimizer.rs:
##########
@@ -384,11 +380,9 @@ impl Optimizer {
let result = match rule.apply_order() {
// optimizer handles recursion
- Some(apply_order) => new_plan.rewrite(&mut Rewriter::new(
Review Comment:
I think we owe a significant debt to @peter-toth for his work on the tree
node API to sort out how to handle subqueries
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
