comphead commented on code in PR #13053:
URL: https://github.com/apache/datafusion/pull/13053#discussion_r1809687519
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -746,21 +750,21 @@ fn last_index_for_row(
// `false` - the row sent as NULL joined row
fn get_corrected_filter_mask(
join_type: JoinType,
- indices: &UInt64Array,
- ids: &[usize],
+ row_indices: &UInt64Array,
Review Comment:
renamed variables for readability
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
