agscpp commented on code in PR #13001:
URL: https://github.com/apache/datafusion/pull/13001#discussion_r1808363886
##########
datafusion/expr/src/udf.rs:
##########
@@ -469,6 +480,21 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
/// [invoke_no_args]: ScalarUDFImpl::invoke_no_args
fn invoke(&self, _args: &[ColumnarValue]) -> Result<ColumnarValue>;
+ /// Invoke the function with `args` and the number of rows,
+ /// returning the appropriate result.
+ /// The function is called for signatures with
[`datafusion_expr_common::signature::Volatility::Volatile`]
+ /// and with arguments
+ fn invoke_batch(
+ &self,
+ _args: &[ColumnarValue],
+ _number_rows: usize,
+ ) -> Result<ColumnarValue> {
+ not_impl_err!(
+ "Function {} does not implement invoke_batch but called",
+ self.name()
+ )
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
