adriangb commented on code in PR #12978:
URL: https://github.com/apache/datafusion/pull/12978#discussion_r1805367279
##########
datafusion/core/src/physical_optimizer/pruning.rs:
##########
@@ -1487,6 +1489,17 @@ fn build_predicate_expression(
*bin_expr.op(),
bin_expr.right().clone(),
)
+ } else if let Some(like_expr) =
expr_any.downcast_ref::<phys_expr::LikeExpr>() {
+ if like_expr.case_insensitive() {
+ return unhandled_hook.handle(expr);
+ }
+ let op = match (like_expr.negated(), like_expr.case_insensitive())
{
+ (false, false) => Operator::LikeMatch,
+ (true, false) => Operator::NotLikeMatch,
+ (false, true) => Operator::ILikeMatch,
+ (true, true) => Operator::NotILikeMatch,
Review Comment:
Sure will change it to do so. I think I was getting a bit ahead of myself to
implement `ILIKE` support, which as per the comment should be possible, maybe
you can show me how to construct the physical expression to call `lower()` and
`upper()` on another expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
