jcsherin commented on code in PR #12811:
URL: https://github.com/apache/datafusion/pull/12811#discussion_r1801528220
##########
datafusion/physical-plan/src/windows/mod.rs:
##########
@@ -217,6 +217,41 @@ fn get_casted_value(
}
}
+fn rewrite_null_expr_and_data_type(
Review Comment:
> for the naming its little bit abstract however its still good name but to
help contributors understand what this method exactly doing lets add comments.
>
> Having comments method increases chances that method can be reusable in
future if the similar case shows up
💯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
