Omega359 commented on code in PR #12926:
URL: https://github.com/apache/datafusion/pull/12926#discussion_r1800168378
##########
datafusion/functions/src/string/replace.rs:
##########
@@ -96,9 +96,9 @@ fn get_replace_doc() -> &'static Documentation {
| ABcdbaBA |
+-------------------------------------------------+
```"#)
- .with_standard_argument("str", "String")
- .with_standard_argument("substr", "Substring expression to replace
in the input string. Substring expression")
- .with_standard_argument("replacement", "Replacement substring")
+ .with_standard_argument("str", Some("String"))
+ .with_standard_argument("substr", Some("Substring expression to
replace in the input string. Substring expression"))
Review Comment:
This seems odd, as it would result in "Substring expression to replace in
the input string. Substring expression expression to operate on. Can be a
constant, column, or function, and any combination of operators."
likely would just want that one to be .with_argument(...) with complete text.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
