jatin510 commented on code in PR #12893:
URL: https://github.com/apache/datafusion/pull/12893#discussion_r1797690877
##########
datafusion/functions-window/src/rank.rs:
##########
@@ -39,37 +39,76 @@ use field::WindowUDFFieldArgs;
define_udwf_and_expr!(
Rank,
rank,
- "Returns rank of the current row with gaps. Same as `row_number` of its
first peer"
+ "Returns rank of the current row with gaps. Same as `row_number` of its
first peer",
+ Rank::basic
);
+// define_udwf_and_expr!(
Review Comment:
@jcsherin while defining the other udwf like this, it is not working, giving
an error during compile time.
Am I going in the right direction ?
Thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
