jayzhan211 commented on code in PR #12864:
URL: https://github.com/apache/datafusion/pull/12864#discussion_r1797538494
##########
datafusion/sqllogictest/test_files/group_by.slt:
##########
@@ -3579,8 +3580,7 @@ physical_plan
08)--------------RepartitionExec: partitioning=RoundRobinBatch(8),
input_partitions=1
09)----------------ProjectionExec: expr=[zip_code@0 as zip_code, country@1 as
country, sn@2 as sn, ts@3 as ts, currency@4 as currency, amount@5 as amount,
sum(l.amount) ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING@6 as sum_amount]
10)------------------BoundedWindowAggExec: wdw=[sum(l.amount) ROWS BETWEEN 1
PRECEDING AND 1 FOLLOWING: Ok(Field { name: "sum(l.amount) ROWS BETWEEN 1
PRECEDING AND 1 FOLLOWING", data_type: Float64, nullable: true, dict_id: 0,
dict_is_ordered: false, metadata: {} }), frame: WindowFrame { units: Rows,
start_bound: Preceding(UInt64(1)), end_bound: Following(UInt64(1)), is_causal:
false }], mode=[Sorted]
-11)--------------------CoalescePartitionsExec
-12)----------------------MemoryExec: partitions=8, partition_sizes=[1, 0, 0,
0, 0, 0, 0, 0]
+11)--------------------MemoryExec: partitions=1, partition_sizes=[1]
Review Comment:
This looks like improvement
##########
datafusion/sqllogictest/test_files/group_by.slt:
##########
@@ -3360,7 +3360,8 @@ physical_plan
05)--------CoalesceBatchesExec: target_batch_size=4
06)----------RepartitionExec: partitioning=Hash([sn@0, amount@1], 8),
input_partitions=8
07)------------AggregateExec: mode=Partial, gby=[sn@0 as sn, amount@1 as
amount], aggr=[]
-08)--------------MemoryExec: partitions=8, partition_sizes=[1, 0, 0, 0, 0, 0,
0, 0]
+08)--------------RepartitionExec: partitioning=RoundRobinBatch(8),
input_partitions=1
+09)----------------MemoryExec: partitions=1, partition_sizes=[1]
Review Comment:
This seems equivalent
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
