findepi commented on code in PR #12846:
URL: https://github.com/apache/datafusion/pull/12846#discussion_r1797443813
##########
datafusion/common/src/test_util.rs:
##########
@@ -333,4 +410,15 @@ mod tests {
let res = parquet_test_data();
assert!(PathBuf::from(res).is_dir());
}
+
+ #[test]
+ fn test_create_record_batch() {
+ let batch = create_batch!(
+ ("a", Int32, vec![1, 2, 3]),
+ ("b", Float64, vec![Some(4.0), None, Some(5.0)]),
+ ("c", Utf8, vec!["alpha", "beta", "gamma"])
+ );
Review Comment:
nice!
##########
datafusion/common/src/test_util.rs:
##########
@@ -333,4 +410,15 @@ mod tests {
let res = parquet_test_data();
assert!(PathBuf::from(res).is_dir());
}
+
+ #[test]
+ fn test_create_record_batch() {
+ let batch = create_batch!(
+ ("a", Int32, vec![1, 2, 3]),
+ ("b", Float64, vec![Some(4.0), None, Some(5.0)]),
+ ("c", Utf8, vec!["alpha", "beta", "gamma"])
+ );
+
+ assert!(batch.is_ok());
Review Comment:
should we assert the contents too?
##########
datafusion/common/src/test_util.rs:
##########
@@ -279,6 +279,83 @@ pub fn get_data_dir(
}
}
+#[macro_export]
+macro_rules! create_array {
+ (Boolean, $values: expr) => {
+ std::sync::Arc::new(arrow::array::BooleanArray::from($values))
+ };
+ (Int8, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Int8Array::from($values))
+ };
+ (Int16, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Int16Array::from($values))
+ };
+ (Int32, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Int32Array::from($values))
+ };
+ (Int64, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Int64Array::from($values))
+ };
+ (UInt8, $values: expr) => {
+ std::sync::Arc::new(arrow::array::UInt8Array::from($values))
+ };
+ (UInt16, $values: expr) => {
+ std::sync::Arc::new(arrow::array::UInt16Array::from($values))
+ };
+ (UInt32, $values: expr) => {
+ std::sync::Arc::new(arrow::array::UInt32Array::from($values))
+ };
+ (UInt64, $values: expr) => {
+ std::sync::Arc::new(arrow::array::UInt64Array::from($values))
+ };
+ (Float16, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Float16Array::from($values))
+ };
+ (Float32, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Float32Array::from($values))
+ };
+ (Float64, $values: expr) => {
+ std::sync::Arc::new(arrow::array::Float64Array::from($values))
+ };
+ (Utf8, $values: expr) => {
+ std::sync::Arc::new(arrow::array::StringArray::from($values))
+ };
+}
+
+/// Creates a record batch from literal slice of values, suitable for rapid
+/// testing and development.
+///
+/// Example:
+/// ```
+/// use datafusion_common::{create_batch, create_array};
+/// let batch = create_batch!(
+/// ("a", Int32, vec![1, 2, 3]),
+/// ("b", Float64, vec![Some(4.0), None, Some(5.0)]),
+/// ("c", Utf8, vec!["alpha", "beta", "gamma"])
+/// );
+/// ```
+#[macro_export]
Review Comment:
does this affect how the macro is imported? do we need this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
