alamb commented on code in PR #12822:
URL: https://github.com/apache/datafusion/pull/12822#discussion_r1797049163
##########
datafusion/functions/src/datetime/to_date.rs:
##########
@@ -26,9 +26,42 @@ use
datafusion_expr::scalar_doc_sections::DOC_SECTION_DATETIME;
use datafusion_expr::{
ColumnarValue, Documentation, ScalarUDFImpl, Signature, Volatility,
};
+use datafusion_macros::udf_doc;
use std::any::Any;
use std::sync::OnceLock;
+#[udf_doc(
Review Comment:
this is very cool
@Omega359 what do you think?
##########
Cargo.toml:
##########
@@ -48,6 +48,8 @@ members = [
"datafusion-examples",
"test-utils",
"benchmarks",
+ "datafusion/macros",
+ "datafusion/pre-macros"
Review Comment:
if we go with this approach, maybe we can put the doc structure in a crate
named specifically such as `datafusion/documentation` rather than something
generic like `pre-macro`s
##########
datafusion/macros/Cargo.toml:
##########
@@ -0,0 +1,43 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+[package]
+name = "datafusion-macros"
+description = "Proc macros for DataFusion query engine"
Review Comment:
```suggestion
description = "Procedural macros for DataFusion query engine"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
