adriangb commented on PR #12850:
URL: https://github.com/apache/datafusion/pull/12850#issuecomment-2407523130
> I think callers could probably get the schema in other ways. However, it
might be nice to pass it in too.
I just meant:
```rust
let known_expression_transformed = StatisticsPredicateRewriter::new()
.rewrite(
&logical2physical(&known_expression, &schema)
&schema)
);
```
vs
```rust
let known_expression_transformed =
StatisticsPredicateRewriter::new(schema)
.rewrite(&logical2physical(&known_expression, &schema));
```
I think both work, I don't see a reason to change it but was just double
checking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
