vaibhawvipul commented on PR #981: URL: https://github.com/apache/datafusion-comet/pull/981#issuecomment-2401911313
> Thanks for working on this @vaibhawvipul. > > I checked Spark's source code in the master branch, and it also hard codes nullable as true. This makes sense because if we perform a sum on a column that only contains nulls, then we would expect a null output. > > It would be good to add a test in `CometAggregateSuite` to confirm that we have the same behavior as Spark in this case. > > Parth raises a good point that we should check that we have the behavior for the ANSI overflow case, but that can be a separate issue/PR. @andygrove I have added a test in CometAggregateSuite and we can observe that we have behaviour parity with spark. I can work on the issue raised by Parth in a separate PR. Please let me know your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
