alamb commented on code in PR #12332:
URL: https://github.com/apache/datafusion/pull/12332#discussion_r1777747273
##########
datafusion/physical-plan/src/aggregates/row_hash.rs:
##########
@@ -1024,11 +1017,7 @@ impl GroupedHashAggregateStream {
/// Note: currently spilling is not supported for Partial aggregation
fn update_skip_aggregation_probe(&mut self, input_rows: usize) {
if let Some(probe) = self.skip_aggregation_probe.as_mut() {
- if !self.spill_state.spills.is_empty() {
Review Comment:
I agree -- adding an assertion would be great. Can you perhaps make a PR to
do so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
