goldmedal commented on code in PR #12620:
URL: https://github.com/apache/datafusion/pull/12620#discussion_r1775409595
##########
datafusion/physical-plan/src/aggregates/group_values/column_wise.rs:
##########
@@ -154,7 +187,9 @@ impl GroupValues for GroupValuesColumn {
let b =
ByteGroupValueBuilder::<i64>::new(OutputType::Binary);
v.push(Box::new(b) as _)
}
- dt => todo!("{dt} not impl"),
+ dt => {
+ return internal_err!("{dt} not supported in
GroupValuesColumn")
Review Comment:
```suggestion
return not_impl_err!("{dt} not supported in
GroupValuesColumn")
```
It was todo!() previously, which I assume means we might implement it in the
future. How about using `not_impl_err` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
