andygrove commented on code in PR #962:
URL: https://github.com/apache/datafusion-comet/pull/962#discussion_r1774114004
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1263,21 +1268,6 @@ impl PhysicalPlanner {
None
};
- // DataFusion Join operators keep the input batch internally. We need
- // to copy the input batch to avoid the data corruption from reusing
the input
- // batch.
- let left = if can_reuse_input_batch(&left) {
- Arc::new(CopyExec::new(left, CopyMode::UnpackOrDeepCopy))
- } else {
- Arc::new(CopyExec::new(left, CopyMode::UnpackOrClone))
- };
-
- let right = if can_reuse_input_batch(&right) {
- Arc::new(CopyExec::new(right, CopyMode::UnpackOrDeepCopy))
- } else {
- Arc::new(CopyExec::new(right, CopyMode::UnpackOrClone))
- };
-
Review Comment:
This code is specific to HashJoinExec and not to SortMergeJoinExec, so I
moved it out of this code, which is common to both joins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
