Blizzara commented on code in PR #12374:
URL: https://github.com/apache/datafusion/pull/12374#discussion_r1771016885
##########
datafusion/expr/src/udwf.rs:
##########
@@ -324,14 +317,8 @@ pub trait WindowUDFImpl: Debug + Send + Sync {
hasher.finish()
}
- /// Allows customizing nullable of column for this window UDF.
- ///
- /// By default, the final result of evaluating the window UDF is
- /// allowed to have null values. But if that is not the case then
- /// it can be customized in the window UDF implementation.
- fn nullable(&self) -> bool {
- true
- }
+ /// The [`Field`] of the final result of evaluating this window function.
Review Comment:
Could be useful to document here how the "name" for the returned field is
supposed to be set :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
