alamb commented on code in PR #3021:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/3021#discussion_r4645439879
##########
tests/sqlparser_sqlite.rs:
##########
@@ -2010,3 +2015,105 @@ fn
parse_create_table_string_literal_column_with_dangling_constraint_name() {
"sql parser error: Expected: constraint details after CONSTRAINT
<name>, found: )"
);
}
+
+#[test]
+fn parse_create_virtual_table_module_arguments() {
Review Comment:
minor it might be nicer if you broke the test into multiple `fn` so they ran
in parallel / were more self contained (and the name of the function could
self-document what they were testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]