Omkar-Wagholikar commented on PR #27544: URL: https://github.com/apache/datafusion/pull/27544#issuecomment-6997863603
Hi @kumarUjjawal, thanks for the review. I've pushed a commit addressing all three comments: - true_exists is now built only in the Any branch. - I removed the clone in unmatched_having_default. I kept the one in having_arm, because is_not_true() takes ownership and the original expression is still needed afterwards. - I fixed the comment to say "two cases". Could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
