andygrove opened a new pull request, #370:
URL: https://github.com/apache/datafusion-spark/pull/370

   ## Which issue does this PR close?
   
   - Part of #56.
   
   ## Rationale for this change
   
   `main` depends on DataFusion's `branch-56` as a git dependency, so the 
DataFusion code we build against changes whenever `branch-56` moves. Pinning to 
the `56.0.0-rc2` tag means we build and test against the release candidate. 
When DataFusion 56.0.0 is published, a follow-up PR moves to the crates.io 
release.
   
   ## What changes are included in this PR?
   
   - The DataFusion dependencies in `Cargo.toml` and 
`crates/sqllogictest/Cargo.toml` use `tag = "56.0.0-rc2"` instead of `branch = 
"branch-56"`. `Cargo.lock` changes only the DataFusion git sources.
   - The note on git dependencies in `dev/release/README.md` now mentions tags 
too.
   
   ## Are these changes tested?
   
   By the existing tests in CI. Locally, everything passes except 
`math/expm1.slt`, which also fails on `main` on macOS (#358, fixed by #359).
   
   ## Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to