mightsleep commented on PR #26599: URL: https://github.com/apache/datafusion/pull/26599#issuecomment-6988362920
Yes hello, I looked at the two `right/string` cases. They are ASCII inputs, so they never reach the new scan. I compared the aarch64 asm of both builds: `left_right_byte_length` is called out of line in both, the ASCII path has the same instructions, and nothing in the loop of `RightFunc::invoke_with_args` gets spilled to the stack. What differs is where the code ends up, so I think this is code layout and not something the change does. The layout changed again with the rebase, so could someone rerun the benchmark on the new head? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
