andygrove opened a new pull request, #7679: URL: https://github.com/apache/datafusion-comet/pull/7679
## Which issue does this PR close? There is no issue. This came up while investigating CI failures on the branch-1.2 backports. ## Rationale for this change No test or build job in our workflows sets `timeout-minutes`, so each one gets GitHub's six hour default. On #7645 the `PR Build (Linux) / Spark 3.4, JDK 17, Scala 2.12 [shuffle]` job hung in `CometShuffleSuite` at 21:54 and was cancelled at 03:49. The same job takes 10 to 14 minutes on other pull requests. For those six hours it held a runner, and nobody saw a failure. ## What changes are included in this PR? Every job that runs on a runner now sets `timeout-minutes`. Each limit is about two to three times the slowest successful run of that job across recent merge queue, nightly and pull request runs, rounded up. | Jobs | Slowest seen | Limit | |---|---|---| | macOS test matrix | 83 min | 180 | | Spark SQL shards, Iceberg suites, Delta contrib | 46 to 54 min | 120 | | Native builds, Linux PR test matrix, Miri | 26 to 46 min | 90 | | Rust tests, native executors, TPC-H and TPC-DS verify, PyArrow UDF, Delta build gate | 11 to 26 min | 60 | | Lint, Preflight, CodeQL, benchmark check | under 10 min | 30 | | Change detection, Required Checks, nightly report and other housekeeping | under 1 min | 10 to 15 | A job that calls a reusable workflow cannot set `timeout-minutes`, so the limits are on the jobs inside `pr_build_linux.yml`, `spark_sql_test_reusable.yml` and the other reusable workflows. Every limit is well below the merge queue's `check_response_timeout_minutes: 300`. A new "Job timeouts" section in `.github/workflows/README.md` explains how the limits were chosen. It also says that a pull request that makes a job slower should raise that job's limit, not remove it. ## How are these changes tested? Every workflow file still parses, and a script confirmed that every job with `runs-on` now has `timeout-minutes`. The README passes `prettier --check`. This pull request's own CI runs under the new limits. Some limits are based on only two successful runs, mostly with a warm cache, so the build limits are set generously to allow for a cold cache. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
