comphead commented on code in PR #12520: URL: https://github.com/apache/datafusion/pull/12520#discussion_r1765292124
########## datafusion/core/src/dataframe/mod.rs: ########## @@ -244,6 +244,30 @@ impl DataFrame { .collect(); self.select(expr) } + /// Project arbitrary expression strings into a new `DataFrame`. + /// + /// The output `DataFrame` has one column for each element in `exprs`. + /// + /// # Example + /// ``` + /// # use datafusion::prelude::*; + /// # use datafusion::error::Result; + /// # #[tokio::main] + /// # async fn main() -> Result<()> { + /// let ctx = SessionContext::new(); + /// let df = ctx.read_csv("tests/data/example.csv", CsvReadOptions::new()).await?; + /// let df = df.select_exprs(&["a * b", "c"])?; + /// # Ok(()) Review Comment: why do we have commented out parts of example? 🤔 and I found it would be really nice to have an expected answer in example. Like what exactly `select_exprs` returns -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org