andygrove opened a new pull request, #7665:
URL: https://github.com/apache/datafusion-comet/pull/7665

   ## Which issue does this PR close?
   
   Backport of #7617 to `branch-1.2`. Closes #7609 on this branch.
   
   ## Rationale for this change
   
   Rust 1.100 became the stable toolchain on 2026-11-12, and `branch-1.2`'s 
`rust-toolchain.toml` tracks `stable`. Cargo 1.100 splits a build script's 
`OUT_DIR` into `build/<pkg>/<hash>/out`, so the fixed-depth lookup in 
`native/core/build.rs` now points `COMET_TEST_UDFS_LIB` at 
`target/debug/build/libcomet_test_udfs.so`. The `c_udf` loader tests then fail 
to load the library, and `rust-test` fails on every pull request against 
`branch-1.2`, including the open backports #7513, #7514 and #7515. See #7617 
for the full analysis.
   
   ## What changes are included in this PR?
   
   Cherry-pick of d504163b1 (`git cherry-pick -x`) with no conflicts and no 
adaptations. `build.rs` now finds the profile directory as the parent of the 
nearest `build` ancestor of `OUT_DIR`, which works under both Cargo layouts.
   
   Other release branches: `branch-1.2` is the newest release branch. 
`branch-1.1` and older don't have the `c_udf` loader or `COMET_TEST_UDFS_LIB`, 
so they don't need this.
   
   ## How are these changes tested?
   
   On this branch with Rust 1.100.0 (macOS), after `cargo build -p 
comet-test-udfs`, the 42 `c_udf` unit tests pass (`cargo test -p 
datafusion-comet --lib c_udf`). With `build.rs` reverted to `branch-1.2`'s 
version, the same tests fail to load the library, which matches the `rust-test` 
failures on #7513, #7514 and #7515.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to