laxmanmamididd commented on PR #7363: URL: https://github.com/apache/datafusion-comet/pull/7363#issuecomment-6935022517
Thanks for the review, @andygrove. This PR had a conflict with `main`, so I pushed two things: - The branch now sits on #7464's latest commit (6a3279e1a). That commit answers the `supersedes` question on #7464: only a later token expiry evicts a cached `FileIO`. - Merging `main` in (6a127bdb2) clears the conflicts from the HDFS-backed Iceberg scan (#5898). In `CometScanRule`, the catalog properties now include `main`'s `derivedHdfsProperties` and still go through `withVendedCredentialProvider`. `CometIcebergNativeScanSuite` keeps both sets of `java.net` imports. Tested locally on Spark 4.0 and JDK 17 after the merge: - `IcebergVendedS3CredentialProviderTest`, `IcebergRESTVendedS3ProviderTest` and `CometS3CredentialDispatcherTest`: 34 passed. - `CometIcebergNativeScanSuite`, `CometIcebergNativeSuite`, `CometS3CredentialReleaseSuite` and `CometS3CredentialBridgeSuite`: all pass, with 6 canceled by version gates. - `iceberg_common` Rust tests: 31 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
