aetherxeg-source commented on PR #2775: URL: https://github.com/apache/datafusion-ballista/pull/2775#issuecomment-6933474036
@andygrove Following up on the narrowed fix for #2767, now at `09ecf8caa322c29ec57c2e9e1f7bebbffd987e93`. The revised PR contains a **one-file** change: keep the default `TempDir` guard alive for the executor's lifetime, enforce Unix `0700`, and add a focused lifetime/cleanup regression. The earlier process-wide lease registry and shuffle-writer changes are gone, and the description now follows the PR template. The revised candidate passed **101/101 local executor library tests**, Clippy (`-D warnings`), `cargo fmt --check`, and a local Scheduler + Executor lifecycle check. Those results do **not** replace upstream CI. On GitHub, the `Process` check succeeded, but the Rust/build workflows for this commit remain `action_required`; the existing changes-requested review predates the revision. Would you or another Ballista maintainer be able to re-review the reduced patch and approve the pending CI runs, if appropriate? I will address any specific findings on this same PR. Thank you for the earlier guidance. AETHER X GLOBAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
