andygrove commented on issue #11570: URL: https://github.com/apache/datafusion/issues/11570#issuecomment-6933084308
Closing as not planned. Several PRs tried to special-case this pattern (#12049, #14200, #19994, #24402), but the reviews showed the gain depends heavily on how many denominators are zero, and none was merged. In the meantime, the general CASE path got faster through #20097 (`CASE WHEN x THEN y ELSE NULL`) and #20498 (`scatter`), and this pattern benefits from both. If someone has a benchmark showing a clear win across the whole range of zero ratios, a new issue or PR is welcome. Thanks to everyone who worked on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
