jayzhan211 commented on code in PR #12269:
URL: https://github.com/apache/datafusion/pull/12269#discussion_r1762826775
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1380,24 +1380,16 @@ mod tests {
"+---+-----+-----------------+",
"| a | b | COUNT(1)[count] |",
"+---+-----+-----------------+",
- "| | 1.0 | 1 |",
Review Comment:
The change is consistent with the one that run in slt in `main`.
Not sure which one is the expected behaviour 🤔
The only difference is that we use `GroupValuesRowLike` instead
`GroupValuesRows` for Float
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
