Awesome06 commented on PR #27244:
URL: https://github.com/apache/datafusion/pull/27244#issuecomment-6825622517

   Thanks for the catch and the helpful pointers, @jayzhan211! Pushed an update 
with your suggestions:
   
   - Replaced the duplicate counter with `check_alias_keeps_column_name` so 
queries where the correlated column is the first occurrence continue to work, 
while later ones fail with the new message naming the column.
   - Added the same check to `requalify_filter` in 
`decorrelate_lateral_join.rs` so LATERAL joins fail fast instead of returning 
wrong rows.
   - Added the LATERAL query error test, updated the 5 existing error queries, 
added passing tests for the non-ambiguous cases, and updated the unit test in 
`decorrelate.rs`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to