abhinavgautam01 commented on PR #1685: URL: https://github.com/apache/datafusion-ballista/pull/1685#issuecomment-6817615277
Thanks @andygrove, rebased onto main and trimmed to test changes only. The executor and scheduler changes are gone since #2669 covers them. context_checks and context_unsupported now run each test under push-staged too, through two extra cases (standalone_push, remote_push) built from a session state with ballista.standalone.task_scheduling_policy = push-staged. Existing test bodies are unchanged. rstest 0.28 still doesn't accept #[values] on fixture params, so the policy is added as cases rather than a parametrized fixture. One exception: should_support_hash_join_when_opted_in keeps only its pull cases. A scheduler built from a session state plans with that state and ignores the client's SET (pull with a custom state fails the same way), so I left a comment there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
