andygrove commented on code in PR #6996:
URL: https://github.com/apache/datafusion-comet/pull/6996#discussion_r4543723573
##########
spark/src/main/scala/org/apache/comet/serde/operator/IcebergWriteProtoTranslation.scala:
##########
@@ -100,6 +100,15 @@ object IcebergWriteProtoTranslation {
}
}
+ /**
+ * True when the write compresses with brotli. Unlike `resolveCompression`,
never throws. The
+ * name is matched the way iceberg-java matches it, upper-cased with
`Locale.ENGLISH`, so that
+ * `BROTLI` counts. It is also trimmed, so that a padded name, which the
codec parsing here
+ * accepts, is checked too.
Review Comment:
Thanks. I removed the second `trim` in `0c0ce509c7`, since `codecName` has
already trimmed. I kept the `Locale.ENGLISH` upper-casing so the comparison
does not depend on how `codecName` normalizes, which was the concern with #7027
rewriting it, and the scaladoc now says what `codecName` does first. The
padded-name case in the unit test still passes, and so do the translation and
detection suites (102 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
