Sruhvx-jpg commented on PR #27317:
URL: https://github.com/apache/datafusion/pull/27317#issuecomment-6801428931
Thanks @alamb! I asked my clanker to perform a research on your concern and
this is my review of the research:
1. **`ListingTableConfig::expr_adapter_factory(&self)`**:
`ListingTableConfig` has `with_expr_adapter_factory(...)`, but the field
is `pub(crate)` with no getter. Since this PR is already touching adapter
accessors, I can add it here if you want.
2. **`ListingTable::file_schema(&self) -> &SchemaRef`**:
`table.schema()` returns `table_schema` (file schema + partition
columns), so there's currently no way to get the raw file schema directly
(which caused the partition-filtering workaround in #27314).
3. **`ListingTable::cache(&self) -> Option<&Arc<FileStatisticsCache>>`**:
`with_cache(...)` exists, but there's no getter to read the cache back
out.
I can open separate PRs for `file_schema` and `cache`. Should I add the
`ListingTableConfig::expr_adapter_factory` getter to this PR, or save that for
a separate PR too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
