ErikBPF commented on PR #7579: URL: https://github.com/apache/datafusion-comet/pull/7579#issuecomment-6799251614
@comphead both points are addressed in `b150863`: - `invalid_timestamp(value, eval_mode)` at `string.rs:2128` now backs the empty-input arm (`:1521`), the residual-offset underflow (`:1551`) and `parse_timestamp_pattern` (`:2075`). The `TIMESTAMP` path has one copy and mirrors `invalid_ntz_timestamp`. - Added the rejected `2020-06-15T12:30:00+8:0:3` layout to the `TIMESTAMP_NTZ` values list. Spark's `parseTimestampString` calls `getZoneId` before the zone is dropped, so NTZ also returns NULL for it; the parser already did, and the test now pins that. Verification: `cargo fmt --check` and `cargo test -p datafusion-comet-spark-expr --lib timestamp_parser` on Apollo (8 passed). The Scala suite was not run locally for the one-line list addition; CI covers it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
