MisterRaindrop commented on PR #26264: URL: https://github.com/apache/datafusion/pull/26264#issuecomment-6798909235
> Ran this locally: slt, the extended sort/spill/window/aggregate fuzz tests and memory_limit all pass, and an A/B against the merge base showed no timing or spill difference for in-memory and spilling sorts. > > One question: `partitions_reading_input` only goes down in `sort()`, so a partition whose stream is dropped early stays counted. With three partitions, dropping 0 and finishing 1 and 2 leaves it at 1, and later merges keep headroom for nobody. Output is fine. Worth a small drop guard, here or as a follow up? > > Nit: `fetch_sub` can wrap on re-execute without `reset_state`; a saturating `fetch_update` would avoid that. do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
