mbutrovich commented on PR #25584: URL: https://github.com/apache/datafusion/pull/25584#issuecomment-6775036825
Just glancing at this, I am going to voice the same concern I raised here https://github.com/apache/datafusion/pull/27278#pullrequestreview-5843773751 > In the context of #26257, I'm concerned that this PR complicates a stream that #23976 refactored for simplicity, and does it for a degenerate case ... I'd like to make sure we're optimizing for the common case ... I will take a review pass through this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
