dragonknightk commented on PR #27115: URL: https://github.com/apache/datafusion/pull/27115#issuecomment-6769832626
Hi @parthchandra! This is my first contribution to DataFusion, so please bear with me if I've missed anything (´｡• ᵕ •｡`) This PR fixes #26891, which you opened: when groups are emitted, the accumulator now subtracts the actual bytes of the emitted values instead of the row count. I noticed you ran into the same issue in apache/datafusion-comet#7191, and the fix here follows the same idea as your approach there. Since I'm a first-time contributor, the upstream CI needs a committer's approval before it runs. The Rust, Dev and Dependencies checks have all passed on my fork. When you have a moment, could you click "Approve and run workflows"? Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
