haochunchang commented on issue #14429: URL: https://github.com/apache/datafusion/issues/14429#issuecomment-6767221759
Organizing the related issues and PRs' reviews with the help of AI, there are 3 decisions that stand out: 1. What does "DONE" mean in this EPIC? (related: https://github.com/apache/datafusion/issues/22131#issuecomment-4440344606) a. Every error type listed here has a diagnostic. b. Diagnostics are visible to end users by default. 2. Do duplicate relation names keep today's plan-or-fail behavior? ( Blocks: [#14436](https://github.com/apache/datafusion/issues/14436); the acceptance criteria of [#21616](https://github.com/apache/datafusion/issues/21616). a. Keep, then no breaking change, with some cases still plan. 3. Where do function-argument diagnostics get their spans? (Blocks: [#14431](https://github.com/apache/datafusion/issues/14431), [#14432](https://github.com/apache/datafusion/issues/14432); the span source for [#15276](https://github.com/apache/datafusion/issues/15276).) a. Best available span from existing `Expr` s -> Not breaking but several cases get no span. b. Add span fields to the `ScalarFunction`, `AggregateFunction` and `WindowFunction` -> Exact spans, but introduce breaking change. For detail review from AI's output: see [epic-review.md](https://github.com/user-attachments/files/34628868/epic-review.md) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
