tlfua commented on PR #7457: URL: https://github.com/apache/datafusion-comet/pull/7457#issuecomment-6756849516
@coderfender thanks for the review and for adding the labels. 1. `containsType` / dead timestamp arms: done in https://github.com/apache/datafusion-comet/commit/37be546ae3b04a281169322e4d7045171dfda9cc . `cannotFail` uses `SupportLevel.containsType` as you suggested, the local `isTimestamp` and `existsNested` are gone, and `isAtomicCastType` no longer lists the timestamp types. 2. `cannotThrow`: opened https://github.com/apache/datafusion-comet/issues/7585 and linked it in https://github.com/apache/datafusion-comet/pull/7457#discussion_r4460105722 . Fork CI on the new commit is green: https://github.com/tlfua/datafusion-comet/actions/runs/42730158514 . Could you approve the workflows on this commit so the labelled Spark 3.5 / 4.1 / all-profiles runs start? They are waiting for approval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
