xudong963 commented on code in PR #27119:
URL: https://github.com/apache/datafusion/pull/27119#discussion_r4520258090
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -7220,6 +7220,247 @@ mod tests {
Ok(())
}
+ /// Aggregate argument that reads `column` and records the data types of
+ /// the columns of every batch it is evaluated against.
+ #[derive(Debug)]
Review Comment:
Thanks, I kept this property test. It checks that unused columns are
replaced with placeholders during argument evaluation, which SQL result tests
cannot observe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
