xavlee commented on code in PR #24497:
URL: https://github.com/apache/datafusion/pull/24497#discussion_r4516105606
##########
datafusion/physical-plan/src/aggregates/mod.rs:
##########
@@ -1044,6 +1044,10 @@ impl AggregateExec {
// states without using group boundaries to recognize completed groups.
if group_by.has_grouping_set() || mode == AggregateMode::PartialReduce
{
group_clustering_mode = GroupClusteringMode::None;
+ } else if num_non_constant_groupby_exprs > 0
Review Comment:
Added 🙇
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
