alamb commented on code in PR #26853:
URL: https://github.com/apache/datafusion/pull/26853#discussion_r4514785000
##########
datafusion/physical-expr/src/equivalence/properties/walk.rs:
##########
@@ -0,0 +1,560 @@
+// SPDX-License-Identifier: Apache-2.0
+// SPDX-FileCopyrightText: See the NOTICE file distributed with this work for
additional information regarding copyright ownership
+// SPDX-FileContributor: Licensed to the Apache Software Foundation (ASF)
under one or more contributor license agreements
+
+use std::sync::Arc;
+
+use super::EquivalenceProperties;
+use crate::equivalence::ordering::is_partial_const;
+use crate::expressions::{Column, Literal};
+use crate::{LexOrdering, PhysicalExpr, PhysicalSortExpr};
+
+use arrow::compute::SortOptions;
+use datafusion_common::tree_node::{Transformed, TransformedResult, TreeNode};
+use datafusion_common::{HashSet, Result};
+use datafusion_expr::interval_arithmetic::Interval;
+use datafusion_expr::sort_properties::{ExprProperties, SortProperties};
+use datafusion_physical_expr_common::sort_expr::options_compatible;
+use datafusion_physical_expr_common::utils::ExprPropertiesNode;
+
+use itertools::Itertools;
+
+/// The state of one walk along a sequence of sort keys, such as the keys of a
Review Comment:
I spent several hours trying to undersstand how this worked, and made a PR
to update the documentation with terms and explanations and examples:
- https://github.com/apache/datafusion/pull/27266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
