dwsmith1983 commented on code in PR #26793:
URL: https://github.com/apache/datafusion/pull/26793#discussion_r4506207071
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -3256,16 +3317,7 @@ fn build_in_memory(
)?;
Review Comment:
Applied in 8c34ddbc4, thanks. The hashed keys are now the same arrays the
probe compares against, so a volatile key expression can't hash one value and
match on another. I also changed the diagram steps to "hash slice N at offset
M", since `update_hash` no longer appears there. The joins tests pass (1867)
and clippy is clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
