vbarua opened a new pull request, #12462: URL: https://github.com/apache/datafusion/pull/12462
## Which issue does this PR close? Part of fixing/implementing #12347 ## Rationale for this change The work for #12347 caused Substrait TPCH test failures. The vendored plans being used for them were quite old, and in fact wrong in some cases. As a result, the tests were updated in the upstream in https://github.com/substrait-io/consumer-testing/pull/105 <!-- Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed. Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes. --> ## What changes are included in this PR? ### Functional Changes * Allows for more flexible handling of IntervalDayToSeconds Substrait literals when the `precision_mode` is not set. ### Test Changes * Brings in updated Substrait TPCH plans from the https://github.com/substrait-io/consumer-testing repo. * Updates TestSchemaCollector to traverse expressions in order to collect schemas that are found in subqueries. ## Are these changes tested? The changes are primarily to tests. Changes were made to allow the tests to continue running. ## Are there any user-facing changes? * A specific IntervalDayToSeconds literal combinations that was rejected before is now allowed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
