alamb commented on issue #11413: URL: https://github.com/apache/datafusion/issues/11413#issuecomment-2350121367
> In my testing, with other things being constant, `StringBuilder` is slower than my hacked DF's `StringArrayBuilder` (by ~10% of the benchmark). My guess this is because of null handling, but didn't measure. ( That would make sense and was the rationale on the original inclusion from @JasonLi-cn (❤️ ) > (The function should be able to declare whether it can declare null result on non-null input, which means null handling can be elided away in the optimal case, without requiring the function body to deal with this.) I think the other thing that is important is if the function produces null on a null input (which has some term but I can't remember now). With those two properties I do think you can skip most null handling. This PR from @kazuyukitanimura in arrow may also help improve the situation for normal arrow `StringBuilder` https://github.com/apache/arrow-rs/pull/6288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
