laxmanmamididd commented on PR #7464: URL: https://github.com/apache/datafusion-comet/pull/7464#issuecomment-6647394216
Thanks, and thanks for checking that a `FileIO` clone keeps the bridge alive under a running scan. Everything is in 40963cfe6, and each point is answered inline: - **Table identity.** A read compares the metadata file's directory and a write compares its data location, so both custom `write.metadata.path` layouts behave. - **`close()` off the reader's thread.** `release` hands the close to a dispatcher-owned daemon thread. The SPI Javadoc and both docs now say when `close()` runs and what it may release. - **The shutdown race.** `closeAll` and the last release both claim an entry by setting it to `RETIRED`, so only one closes it. - **sunchao's test point.** `TestCometS3CredentialProvider` now throws from `getCredentialsForPath` after its own `close()`, so `concurrentAcquireAndReleaseNeverUseAClosedProvider` fails if a provider is closed while in use. - **`supersededSnapshotsAreClosedOnceReleased`** is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
