alamb commented on code in PR #26899: URL: https://github.com/apache/datafusion/pull/26899#discussion_r4472459612
########## datafusion/core/src/optimizer_rule_reference.rs: ########## @@ -1,72 +0,0 @@ -// SPDX-License-Identifier: Apache-2.0 Review Comment: this test existed to ensure the order matches the documentation, but I think now that the list of rules is in the same file as the actual lists it will be much easier (and obvious) that we need to update the docs when we update the actual list ########## datafusion/core/src/lib.rs: ########## @@ -277,18 +277,25 @@ //! possible, significant effort is spent planning and //! optimizing, in the following manner: //! -//! 1. The [`LogicalPlan`] is checked and rewritten to enforce -//! semantic rules, such as type coercion, by [`AnalyzerRule`]s +//! 1. The [`LogicalPlan`] is checked and rewritten by the [`Analyzer`], using Review Comment: I tried to make this introduction clear and provide links to the structures with more detailed documentation for each feature ########## datafusion/core/src/optimizer_rule_reference.rs: ########## @@ -1,72 +0,0 @@ -// SPDX-License-Identifier: Apache-2.0 Review Comment: if this isn't adequate, we can perhaps make individual unit tests in each module that verify the order is correct, rather than something that does it across multiple modules -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
