andygrove commented on code in PR #7053:
URL: https://github.com/apache/datafusion-comet/pull/7053#discussion_r4455773885
##########
native/core/src/execution/operators/parquet_writer.rs:
##########
@@ -514,8 +530,15 @@ impl ExecutionPlan for ParquetWriterExec {
let part_file = self.output_path.clone();
// Configure writer properties
+ let key_value_metadata = self.spark_version.as_ref().map(|version| {
+ vec![KeyValue::new(
+ SPARK_VERSION_METADATA_KEY.to_string(),
+ version.clone(),
+ )]
+ });
Review Comment:
Added `.filter(|v| !v.is_empty())` before the map in 9e402088f, with a
comment on why. The Rust test now covers `Some("3.5.9")`, `Some("")` and `None`.
##########
docs/source/user-guide/latest/parquet.md:
##########
@@ -285,17 +285,22 @@ With `spark.comet.write.parquet.enabled=true`:
- **The datetime rebase modes are ignored.** On Spark 3.4 and 3.5, whose
default rebase mode is
`EXCEPTION`, the native writer writes dates and timestamps before October
15, 1582 that Spark
Review Comment:
Reworded to "dates before October 15, 1582 and timestamps before January 1,
1900". The bullet also now says LEGACY falls back to Spark. Fixed in 9e402088f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
