jayshrivastava commented on code in PR #26593:
URL: https://github.com/apache/datafusion/pull/26593#discussion_r4457165027
##########
datafusion/physical-expr/src/partitioning.rs:
##########
@@ -409,7 +486,8 @@ impl RangePartitioning {
}
}
- /// Adapts this range partitioning to the given expressions, preserving
split points and sort options.
+ /// Adapts this range partitioning to the given expressions, preserving
split points, bounds, and sort options.
+ /// The new expressions must describe the same keys for the bounds to
remain valid.
Review Comment:
Great catch! I just pushed a fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
