fwojciec commented on code in PR #26994:
URL: https://github.com/apache/datafusion/pull/26994#discussion_r4457150104
##########
datafusion/physical-plan/src/joins/hash_join/exec.rs:
##########
@@ -3604,6 +3629,76 @@ mod tests {
Ok(())
}
+ /// The dynamic filter shares the build map and can outlive the join's
+ /// stream and plan, so the map stays reserved until the last holder drops
+ /// it, not only until the partition's stream ends.
+ #[rstest]
+ #[tokio::test]
+ async fn build_map_stays_reserved_with_dynamic_filter(
Review Comment:
Thanks, added as-is in
[499b6512](https://github.com/apache/datafusion/pull/26994/commits/499b6512c643d723b8c31b3735d03a81f071fbbc).
Confirmed that it fails in both modes with the `array_map_key_range` argument
reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
