haochunchang commented on PR #26202: URL: https://github.com/apache/datafusion/pull/26202#issuecomment-6580012732
> I guess I am thinking that rather than fixing random parts of the system (like adding diagnostics to one type of error) we whould somehow decide / commit to revamping the whole feature (like get diagnostics on all messages). Right now it is kind of half done and the feature stalled @alamb I understand your point. It could be clearer if we take a step back to this EPIC (https://github.com/apache/datafusion/issues/14429) about this feature. With all the code review and learnings from the related PRs from that EPIC, the first steps I can think of are: - Collect related issues into the same EPIC (for example, https://github.com/apache/datafusion/issues/21616) - List the known requirements of this feature And I am good to close this PR and organize what I learned from @Phoenix500526 and @kosiew back to the EPIC. The review are still very valuable to me :) What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
