mkleen commented on code in PR #26718: URL: https://github.com/apache/datafusion/pull/26718#discussion_r4425412714
########## datafusion/sqllogictest/test_files/topk.slt: ########## @@ -824,3 +824,50 @@ drop table nested_progress; statement ok set datafusion.execution.target_partitions = 4; + +# The TopK dynamic filter must keep `-0.0` rows when the threshold is `0.0` Review Comment: The tests expect an order we plan to change. The expected rows depend on -0.0 sorting before 0.0. Under #26138, -0.0 and 0.0 will count as equal when sorting, so y decides the order. Then ORDER BY x, y LIMIT 2 should return (0,1), (-0,5) rather than (-0,5), (-0,7), and these tests will fail. That's fine for now, since the bug only happens with today's order. Could you add a comment above the tests so the next person knows why they changed? Something like: ``` # The expected rows assume -0.0 sorts before 0.0 (the current order). # They will change when -0.0 and 0.0 are treated as equal when sorting, # see https://github.com/apache/datafusion/issues/26138 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
